Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vendored sarama version to 1.23.1 #13131

Merged
merged 2 commits into from
Aug 1, 2019
Merged

Conversation

faec
Copy link
Contributor

@faec faec commented Jul 31, 2019

The motivation for this update is to support the IsolationFlag configuration parameter in #12850, but this PR is just a version bump with no functional changes.

@faec faec requested a review from ruflin July 31, 2019 18:27
@faec faec requested review from ph and removed request for ruflin August 1, 2019 18:38
Copy link
Contributor

@ph ph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look a the Sarama code,

LGTM

// IsolationLevel support 2 mode:
// 	- use `ReadUncommitted` (default) to consume and return all messages in message channel
//	- use `ReadCommitted` to hide messages that are part of an aborted transaction

@ph
Copy link
Contributor

ph commented Aug 1, 2019

I've looked at the failing test and its definively not related to this change.

11:26:31 ok  	github.com/elastic/beats/metricbeat/module/rabbitmq/queue	1.105s	coverage: 76.5% of statements
11:26:37 command [go test -race -tags integration -cover -coverprofile /tmp/gotestcover-228237016 github.com/elastic/beats/metricbeat/module/redis/keyspace]: exit status 1
11:26:37 --- FAIL: TestFetch (3.08s)
11:26:37     keyspace_integration_test.go:48: redis/keyspace event: []
11:26:37     keyspace_integration_test.go:51: 
11:26:37         	Error Trace:	keyspace_integration_test.go:51
11:26:37         	Error:      	Should be true
11:26:37         	Test:       	TestFetch
11:26:37 panic: runtime error: index out of range [recovered]
11:26:37 	panic: runtime error: index out of range
11:26:37 
11:26:37 goroutine 18 [running]:
11:26:37 testing.tRunner.func1(0xc000212f00)
11:26:37 	/usr/local/go/src/testing/testing.go:830 +0x69d
11:26:37 panic(0xb96900, 0x1159700)
11:26:37 	/usr/local/go/src/runtime/panic.go:522 +0x1b5
11:26:37 github.com/elastic/beats/metricbeat/module/redis/keyspace.TestFetch(0xc000212f00)
11:26:37 	/go/src/github.com/elastic/beats/metricbeat/module/redis/keyspace/keyspace_integration_test.go:53 +0xa8e
11:26:37 testing.tRunner(0xc000212f00, 0xc522e8)
11:26:37 	/usr/local/go/src/testing/testing.go:865 +0x164
11:26:37 created by testing.(*T).Run

@ph ph added the review label Aug 1, 2019
@faec faec merged commit 08bc430 into elastic:master Aug 1, 2019
@faec faec deleted the kafka-vendor branch August 1, 2019 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants