Skip to content

[metricbeat]fix bucket naming for kubeproxy network programming #12728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2019
Merged

[metricbeat]fix bucket naming for kubeproxy network programming #12728

merged 1 commit into from
Jul 1, 2019

Conversation

odacremolbap
Copy link
Contributor

Kubeproxy metric kubeproxy_network_programming_duration_seconds_bucket shouldn't bring the _bucket suffix

@odacremolbap odacremolbap added Metricbeat Metricbeat containers Related to containers use case Team:Integrations Label for the Integrations team labels Jul 1, 2019
@odacremolbap odacremolbap requested a review from a team as a code owner July 1, 2019 09:20
@odacremolbap
Copy link
Contributor Author

jenkins, test this

1 similar comment
@odacremolbap
Copy link
Contributor Author

jenkins, test this

@odacremolbap odacremolbap mentioned this pull request Jul 1, 2019
Merged
@odacremolbap odacremolbap self-assigned this Jul 1, 2019
kaiyan-sheng
kaiyan-sheng approved these changes Jul 1, 2019
View reviewed changes
Copy link
Contributor

@kaiyan-sheng kaiyan-sheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@odacremolbap odacremolbap merged commit 06185ab into elastic:master Jul 1, 2019
@odacremolbap odacremolbap deleted the fix/kubeproxy-network-programming-bucket branch July 1, 2019 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@exekias exekias exekias approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

Assignees

@odacremolbap odacremolbap

Labels
containers Related to containers use case Metricbeat Metricbeat review Team:Integrations Label for the Integrations team v7.3.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@odacremolbap @exekias @kaiyan-sheng @andresrc