Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add APM to simplified security docs #12456

Merged
merged 10 commits into from
Jun 12, 2019

Conversation

bmorelli25
Copy link
Member

@bmorelli25 bmorelli25 self-assigned this Jun 5, 2019
@bmorelli25 bmorelli25 added the docs label Jun 5, 2019
@bmorelli25 bmorelli25 marked this pull request as ready for review June 11, 2019 17:37
@bmorelli25 bmorelli25 requested a review from a team as a code owner June 11, 2019 17:37
Copy link
Contributor

@dedemorton dedemorton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of minor changes. I didn't build to test the output, but LGTM from eyeballing it.

@bmorelli25
Copy link
Member Author

bmorelli25 commented Jun 12, 2019

In testing I found a build error with heartbeat: they use the no_dashboards attribute which was causing asciidoctor to attempt to build a blank "Privileges needed by {kib} users" table (it doesn't like that). Updated the attribute in 72f854b to only rule out APM Server.

@bmorelli25 bmorelli25 merged commit 25441e6 into elastic:master Jun 12, 2019
@bmorelli25 bmorelli25 deleted the xpack-apm-updates branch June 12, 2019 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants