[7.2] Validate stack modules' metricsets when xpack.enabled = true (#12386) #12429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Checking validity of elasticsearch module with xpack.enabled * Refactoring: extracting validation function * Make the hound happy * More generic comment language * Implement validation for kibana module * Adding CHANGELOG entry
cachedout
reviewed
Jun 5, 2019
| @@ -218,6 +218,10 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
| - Add AWS cloudwatch metricset. {pull}11798[11798] {issue}11734[11734] | |||
| - Add `regions` in aws module config to specify target regions for querying cloudwatch metrics. {issue}11932[11932] {pull}11956[11956] | |||
| - Keep `etcd` followers members from reporting `leader` metricset events {pull}12004[12004] | |||
| - Add overview dashboard to Consul module {pull}10665[10665] | |||
There was a problem hiding this comment.
A few of these entries look unrelated and are not contained in the original PR. Did these get included accidentally.
There was a problem hiding this comment.
Yes, they were indeed 😞. Thanks for catching this. Here's the PR that fixes up the CHANGELOG in 7.2 again: #12474.
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…lastic#12386) (elastic#12429) * Checking validity of elasticsearch module with xpack.enabled * Refactoring: extracting validation function * Make the hound happy * More generic comment language * Implement validation for kibana module * Adding CHANGELOG entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports the following commits to 7.2: