Load configuration from modules.d when running setup subcommand #12340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
May 29, 2019
kvch
force-pushed
the
fix-filebeat-setup-modules.d
branch
2 times, most recently
from
4a536de to
6d22781
Compare
kvch
force-pushed
the
fix-filebeat-setup-modules.d
branch
from
6d22781 to
03a3388
Compare
Co-Authored-By: Jaime Soriano Pastor <jaime.soriano@elastic.co>
Codecov Report
@@ Coverage Diff @@
## master #12340 +/- ##
==========================================
- Coverage 58.02% 57.8% -0.23%
==========================================
Files 933 934 +1
Lines 57454 57485 +31
==========================================
- Hits 33340 33231 -109
- Misses 21050 21192 +142
+ Partials 3064 3062 -2
Continue to review full report at Codecov.
|
jsoriano
approved these changes
Jun 4, 2019
andrewvc
pushed a commit
to andrewvc/beats
that referenced
this pull request
Jun 12, 2019
…tic#12340) Previously, when running the subcommand `setup`, configuration from `modules.d` was not loaded. This lead to Filebeat ignoring settings of modules which had special template directive in their pipelines. Thus, uploading incorrect pipelines. Now when running setup configuration from the modules folder are read and pipelines are loaded. Closes elastic#9747
|
@kvch as this is marked as a bug in CHANGELOG, can you backport it to 7.2? Or is there a reason not to? |
|
No reason. Backporting it. |
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 17, 2019
…tic#12340) Previously, when running the subcommand `setup`, configuration from `modules.d` was not loaded. This lead to Filebeat ignoring settings of modules which had special template directive in their pipelines. Thus, uploading incorrect pipelines. Now when running setup configuration from the modules folder are read and pipelines are loaded. Closes elastic#9747 (cherry picked from commit 5d7c1fa)
kvch
added a commit
to kvch/beats
that referenced
this pull request
Jul 17, 2019
…tic#12340) Previously, when running the subcommand `setup`, configuration from `modules.d` was not loaded. This lead to Filebeat ignoring settings of modules which had special template directive in their pipelines. Thus, uploading incorrect pipelines. Now when running setup configuration from the modules folder are read and pipelines are loaded. Closes elastic#9747 (cherry picked from commit 5d7c1fa)
kvch
added a commit
that referenced
this pull request
Jul 17, 2019
…ing setup subcommand (#12941) * Load configuration from modules.d when running setup subcommand (#12340) Previously, when running the subcommand `setup`, configuration from `modules.d` was not loaded. This lead to Filebeat ignoring settings of modules which had special template directive in their pipelines. Thus, uploading incorrect pipelines. Now when running setup configuration from the modules folder are read and pipelines are loaded. Closes #9747 (cherry picked from commit 5d7c1fa) * add missing function to libbeat/beat/beat.py
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
…en running setup subcommand (elastic#12941) * Load configuration from modules.d when running setup subcommand (elastic#12340) Previously, when running the subcommand `setup`, configuration from `modules.d` was not loaded. This lead to Filebeat ignoring settings of modules which had special template directive in their pipelines. Thus, uploading incorrect pipelines. Now when running setup configuration from the modules folder are read and pipelines are loaded. Closes elastic#9747 (cherry picked from commit 8f27fe8) * add missing function to libbeat/beat/beat.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when running the subcommand
setup, configuration frommodules.dwas not loaded. This lead to Filebeat ignoring settings of the modulesystemand loading incorrect pipelines.Now when running setup configuration from the modules folder are read and pipelines are loaded.
TODO
Closes #9747