Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memory leak in Filebeat pipeline acker #12063

Merged
merged 5 commits into from
May 7, 2019
Merged

Fix memory leak in Filebeat pipeline acker #12063

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0c942e7
Fix memory leak in Filebeat pipeline acker
May 5, 2019
290c4a5
fix `empty` var scope
May 6, 2019
f830863
clarify acker closing condition
May 6, 2019
0a06af9
Add CHANGELOG
May 6, 2019
899d1b6
Update libbeat/publisher/pipeline/acker.go
jsoriano May 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update libbeat/publisher/pipeline/acker.go 
Co-Authored-By: exekias <exekias@gmail.com>
  • Loading branch information
@jsoriano @exekias
jsoriano and exekias authored May 6, 2019
commit 899d1b6c14fa9816ad91c42cb5de5cf2c2f1e1e1
2 changes: 1 addition & 1 deletion libbeat/publisher/pipeline/acker.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ func (a *gapCountACK) ackLoop() {
case n := <-acks:
empty := a.handleACK(n)
if empty && closing && a.events.Load() == 0 {
// stop worker, if all events accounted for have been ACKed
// stop worker, if and only if all events accounted for have been ACKed
return
}

Expand Down