Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to Golang 1.12.4 #11782

Merged
merged 2 commits into from
Apr 16, 2019
Merged

Update to Golang 1.12.4 #11782

merged 2 commits into from
Apr 16, 2019

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Apr 12, 2019 •
edited
Loading

@kvch kvch added the review label Apr 12, 2019
@kvch kvch requested review from urso and mikemadden42 April 12, 2019 13:43
@kvch kvch requested review from a team as code owners April 12, 2019 13:43
andrewkroh
andrewkroh requested changes Apr 12, 2019
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's one at https://github.com/elastic/beats/blob/master/libbeat/docs/version.asciidoc#L3.

andrewkroh
andrewkroh approved these changes Apr 15, 2019
View reviewed changes
Copy link
Member

@andrewkroh andrewkroh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please wait until the 1.12.4 cross-builder images are published before merging.

@kvch
Copy link
Contributor Author

kvch commented Apr 16, 2019

Pushed the crossbuild images.

@kvch kvch merged commit c5937e5 into elastic:master Apr 16, 2019
@kvch
Copy link
Contributor Author

kvch commented Apr 16, 2019

@elastic/apm-server

kvch added a commit that referenced this pull request Apr 23, 2019
@kvch
Add missing changelog entry for #11782
fa27116
@kvch kvch mentioned this pull request Apr 23, 2019
Merged
DStape pushed a commit to DStape/beats that referenced this pull request Aug 20, 2019
@kvch
Update to Golang 1.12.4 (elastic#11782)
443203f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urso urso urso approved these changes

@andrewkroh andrewkroh andrewkroh approved these changes

@mikemadden42 mikemadden42 Awaiting requested review from mikemadden42

Assignees
No one assigned
Labels
review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kvch @urso @andrewkroh