Setup an independent build for x-pack/winlogbeat #11679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Apr 5, 2019
houndci-bot
reviewed
Apr 5, 2019
ruflin
reviewed
Apr 8, 2019
There was a problem hiding this comment.
Skimmed through it and so far looks good to me. But I think me or someone else should go through it again in more detail.
If I understand this correctly quite a few of the changes are actual cleanups of the existing code and not directly related to the x-pack/winlogbeat? I wonder if we should split it up in more PR's? ;-)
andrewkroh
force-pushed
the
feature/wlb/xpack-build
branch
from
eca9fca to
8990542
Compare
This is the split up version of the massive #9842. 😅 |
|
I'm pretty sure I asked there the same question 🤦♂️ |
andrewkroh
force-pushed
the
feature/wlb/xpack-build
branch
2 times, most recently
from
eba6935 to
0002d0e
Compare
ruflin
approved these changes
Apr 29, 2019
|
|
||
| "github.com/elastic/beats/dev-tools/mage" | ||
|
|
||
| // mage:import | ||
| _ "github.com/elastic/beats/dev-tools/mage/target/common" |
There was a problem hiding this comment.
mage:import is great and will simplify things a lot.
| @@ -0,0 +1,60 @@ | |||
| // Licensed to Elasticsearch B.V. under one or more contributor | |||
There was a problem hiding this comment.
This feels quite a bit hidden in scripts package but not something to address for this PR, more a general comment.
|
|
||
| // Dashboards collects all the dashboards and generates index patterns. | ||
| func (Update) Dashboards() error { | ||
| mg.Deps(fb.FieldsYML) |
There was a problem hiding this comment.
Nit: Had to search for the definition of this. Would probably be nicer to have a more descriptive name or defined directly in here.
Put the infrastructure in place to give x-pack/winlogbeat its own independent build.
This adds some utility code that can be used by other beats to reduce duplication.
cd winlogbeat && mage -l
Targets:
goTestUnit is an alias for goUnitTest.
update is an alias for update:all.
check formats code, updates generated content, check for common errors, and checks for any modified files.
clean cleans all generated files and build artifacts.
dumpVariables writes the template variables and values to stdout.
fmt formats source code (.go and .py) and adds license headers.
build builds the Beat binary.
buildGoDaemon builds the go-daemon binary (use crossBuildGoDaemon).
crossBuild cross-builds the beat for all target platforms.
crossBuildGoDaemon cross-builds the go-daemon binary using Docker.
golangCrossBuild build the Beat binary inside of the golang-builder.
packageTest tests the generated packages in build/distributions.
dashboards:export exports a dashboard from Kibana and writes it into the correct directory.
dashboards:import imports dashboards to Kibana using the Beat setup command.
docs generates the documentation for the Beat.
test runs all available tests (unitTest + integTest).
goUnitTest executes the Go unit tests.
pythonUnitTest executes the python system tests.
unitTest executes the unit tests (Go and Python).
update:all updates all generated content.
update:config updates the Beat's config files.
update:dashboards collects all the dashboards and generates index patterns.
update:fieldDocs updates the field documentation.
update:fields updates all fields files (.go, .yml).
package packages the Beat for distribution.
andrewkroh
force-pushed
the
feature/wlb/xpack-build
branch
from
0002d0e to
d650124
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Put the infrastructure in place to give x-pack/winlogbeat its own independent build.
This adds some utility code that can be used by other beats to reduce duplication.