Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Auditbeat] Cherry-pick #10872 to 7.x: Login: Recover from panics, safeguard array access #10881

Merged
merged 1 commit into from
Feb 22, 2019
Merged

[Auditbeat] Cherry-pick #10872 to 7.x: Login: Recover from panics, safeguard array access #10881

merged 1 commit into from
Feb 22, 2019

Conversation

cwurm
Copy link
Contributor

@cwurm cwurm commented Feb 21, 2019

Cherry-pick of PR #10872 to 7.x branch. Original message:

Fixes two concerns in the login dataset:

  1. Since it's using an internal goroutine it should recover from any panics.
  2. Puts in a safeguard for any byte arrays coming from C.

[Auditbeat] Login: Recover from panics, safeguard array access (elast…
1c9c653 
…ic#10872)

Fixes two concerns in the login dataset:

1. Since it's using an internal goroutine it should recover from any panics.
2. Puts in a safeguard for any byte arrays coming from C.

(cherry picked from commit 3cdcb46)
@cwurm cwurm requested a review from a team as a code owner February 21, 2019 22:47
@cwurm cwurm changed the title Cherry-pick #10872 to 7.x: [Auditbeat] Login: Recover from panics, safeguard array access [Auditbeat] Cherry-pick #10872 to 7.x: Login: Recover from panics, safeguard array access Feb 21, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/secops

adriansr
adriansr approved these changes Feb 22, 2019
View reviewed changes
Copy link
Contributor

@adriansr adriansr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cwurm cwurm merged commit c9e82d0 into elastic:7.x Feb 22, 2019
@cwurm cwurm deleted the backport_10872_7.x branch February 22, 2019 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adriansr adriansr adriansr approved these changes

@andrewkroh andrewkroh Awaiting requested review from andrewkroh

Assignees
No one assigned
Labels
Auditbeat backport review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cwurm @elasticmachine @adriansr