Use docker compose file version 2.3 as in other files in beats #10868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
module
review
Metricbeat
sayden
approved these changes
Feb 21, 2019
There was a problem hiding this comment.
According to this https://docs.docker.com/compose/compose-file/compose-versioning/#version-23 no breaking changes seems to happen when upgrading from 2.0 to 2.3 so 👍
|
No blocking here but it will be nice for future reference that you briefly document what have you done to test that this version upgrade is not breaking anything during tests (apart from waiting for CI 😄 ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1 is required to define healthchecks in the docker compose file.
Using 2.3 as is the version used in other beats.