Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Travis failing test in AWS module TestCreateCloudWatchEvents #10498

Merged
merged 1 commit into from
Feb 1, 2019
Merged

Fix Travis failing test in AWS module TestCreateCloudWatchEvents #10498

merged 1 commit into from
Feb 1, 2019

Conversation

kaiyan-sheng
Copy link
Contributor

In travis https://travis-ci.org/elastic/beats/jobs/487488964, it shows ec2_test.go is failing:

FAILURES:
Package: github.com/elastic/beats/x-pack/metricbeat/module/aws/ec2
Test: TestCreateCloudWatchEvents
panic: runtime error: invalid memory address or nil pointer dereference
/home/travis/.gimme/versions/go1.11.5.linux.amd64/src/testing/testing.go:792 +0x387
/home/travis/.gimme/versions/go1.11.5.linux.amd64/src/runtime/panic.go:513 +0x1b9
/home/travis/gopath/src/github.com/elastic/beats/x-pack/metricbeat/module/aws/ec2/ec2.go:177 +0x545
/home/travis/gopath/src/github.com/elastic/beats/x-pack/metricbeat/module/aws/ec2/ec2_test.go:200 +0xc16
/home/travis/.gimme/versions/go1.11.5.linux.amd64/src/testing/testing.go:827 +0xbf
/home/travis/.gimme/versions/go1.11.5.linux.amd64/src/testing/testing.go:878 +0x35c

I can reproduce it locally but somehow it passed Jenkins?!

@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner February 1, 2019 18:34
@kaiyan-sheng kaiyan-sheng self-assigned this Feb 1, 2019
@kaiyan-sheng kaiyan-sheng added the Team:Integrations Label for the Integrations team label Feb 1, 2019
ycombinator
ycombinator approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. WFG.

@ycombinator ycombinator merged commit 652f4b0 into elastic:master Feb 1, 2019
@ycombinator ycombinator mentioned this pull request Feb 1, 2019
Merged
@kaiyan-sheng kaiyan-sheng deleted the fix_travis branch February 1, 2019 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@kaiyan-sheng kaiyan-sheng

Labels
Team:Integrations Label for the Integrations team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kaiyan-sheng @ycombinator