Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick #10179 to 6.6: Revert "Skip x-pack libbeat tests again as flaky (#10068)" #10260

Merged
merged 1 commit into from
Jan 26, 2019

Conversation

ph
Copy link
Contributor

@ph ph commented Jan 22, 2019

Cherry-pick of PR #10179 to 6.6 branch. Original message:

This reverts commit edeed09.

Looking at this with a fresh eyes, I am not sure its flakyness, we should get log from the docker containers on failures.

@ph ph requested a review from ruflin January 22, 2019 18:25
@ph ph changed the title Cherry-pick #10179 to 6.6: [WIP] Revert "Skip x-pack libbeat tests again as flaky (#10068)" Cherry-pick #10179 to 6.6: Revert "Skip x-pack libbeat tests again as flaky (#10068)" Jan 22, 2019
@ph ph added the libbeat label Jan 22, 2019
@ph
Copy link
Contributor Author

ph commented Jan 22, 2019

ok, I will have to use version 2.1, because the other branch use an older version of docker-compose.

@ruflin
Copy link
Contributor

ruflin commented Jan 23, 2019

@ph Perhaps worth updating docker-compose?

@ph
Copy link
Contributor Author

ph commented Jan 23, 2019

This will need #10299

@ph
Copy link
Contributor Author

ph commented Jan 25, 2019

I pushed the File based fix into this PR.

* Enable back CM integration suite

This reverts commit edeed09.

And do the following:

- Move all docker-compose.yml file to the version 2.3 format to have
support for `start_period`
- The health check check the cluster health instead of checking that the
host respond.
- Use the `ELASTIC_PASSWORD` variable instead of invoking the CLI.
- DUMP the last health check information and the docker-compose logs
@ph ph force-pushed the backport_10179_6.6 branch from 5f29033 to c804909 Compare January 26, 2019 01:14
@ph ph merged commit 6758f56 into elastic:6.6 Jan 26, 2019
leweafan pushed a commit to leweafan/beats that referenced this pull request Apr 28, 2023
…astic#10179) (elastic#10260)

* Enable back CM integration suite

This reverts commit 0724101.

And do the following:

- Move all docker-compose.yml file to the version 2.3 format to have
support for `start_period`
- The health check check the cluster health instead of checking that the
host respond.
- Use the `ELASTIC_PASSWORD` variable instead of invoking the CLI.
- DUMP the last health check information and the docker-compose logs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants