Add connection metricset of nats module #10095
Conversation
Signed-off-by: Chris <chrismarkou92@gmail.com> Co-Authored-By: Stamatis Katsaounis <katsaouniss@gmail.com> Co-Authored-By: Michael Katsoulis <michaelkatsoulis88@gmail.com>
|
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
|
jenkins, test this |
Signed-off-by: Chris <chrismarkou92@gmail.com> Co-Authored-By: Stamatis Katsaounis <katsaouniss@gmail.com> Co-Authored-By: Michael Katsoulis <michaelkatsoulis88@gmail.com>
Signed-off-by: Chris <chrismarkou92@gmail.com> Co-Authored-By: Stamatis Katsaounis <katsaouniss@gmail.com> Co-Authored-By: Michael Katsoulis <michaelkatsoulis88@gmail.com>
|
@ruflin, changes applied, feel free to comment and/or trigger the tests! |
| @@ -102,6 +101,8 @@ https://github.com/elastic/beats/compare/v7.0.0-alpha2...master[Check the HEAD d | |||
|
|
|||
| - Add `key` metricset to the Redis module. {issue}9582[9582] {pull}9657[9657] {pull}9746[9746] | |||
| - Add `socket_summary` metricset to system defaults, removing experimental tag and supporting Windows {pull}9709[9709] | |||
| - Add `nats` module with `stats` metricset. {pull}9825[9825] | |||
There was a problem hiding this comment.
Nice find :-) Could you perhaps move both of these lines to CHANGELOG.next.asciidoc. We recently introduced this.
There was a problem hiding this comment.
Sure! I'm in for addressing this in follow up PRs, in order to have it merged and add new metricsets on top of schema changes introduced here.
| "rtt":44269 | ||
| }, | ||
| "nats":{ | ||
| "server_id": "bUAdpRFtMWddIBWw80Yd9D", |
There was a problem hiding this comment.
Do you expect more info about the server then just the id? If yes, perhaps we should make this server.id.
There was a problem hiding this comment.
I had similar thoughts about merging server_id and now fields in something like:
{
"server": {
"id": "foobar",
"reporting_time": ....
}
}
How about introducing this too in follow up PRs?
There was a problem hiding this comment.
I like the idea. Is it reporting_time or is this actually the time of the server? server.time?
There was a problem hiding this comment.
Basically, it's the same thing. So let's keep it as sever.time for simplicity.
There was a problem hiding this comment.
@ChrsMark Can you follow up on this and also do the change for the changelog?
|
jenkins, test this |
|
@ruflin, will it make sense to retry the ci build? |
|
@ChrsMark Merging as Travis is green. We have some CI issues at the moment which we couldn't solve yet. Strange things are happening ... :-( |
This PR adds
connectionsmetricset tonatsmodule as part of #10071.connectionsmetricset retrieves metrics fromconnzmonitoring URI ofnats.Co-Authored-By: Stamatis Katsaounis katsaouniss@gmail.com, @skatsaounis
Co-Authored-By: Michael Katsoulis michaelkatsoulis88@gmail.com, @MichaelKatsoulis