Update CI to test latest version of stack #48
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@JasonStoltz Could I get a review, please? 🙏 |
richkuz
commented
Mar 26, 2021
| @@ -0,0 +1,53 @@ | |||
| # A docker-compose to make it easier to run PHP integration tests locally with different PHP versions. | |||
There was a problem hiding this comment.
As I was wrestling with inconsistent CI build failures, I ended up creating a docker-compose to make it easier to test ideas locally. Thought it might help others in the future.
richkuz
commented
Mar 26, 2021
| name: appsearch | ||
| environment: | ||
| elasticsearch.host: http://elasticsearch:9200 | ||
| elasticsearch.password: password | ||
| ENT_SEARCH_DEFAULT_PASSWORD: password | ||
| secret_management.encryption_keys: "[changeme]" | ||
| allow_es_settings_modification: true | ||
| elasticsearch.startup_retry.interval: 15 |
There was a problem hiding this comment.
This retry interval is a temporary workaround for a known race condition in Enterprise Search startup when waiting for the ES license server to be available. Without it, App Search can sporadically fail to start.
richkuz
commented
Mar 26, 2021
| @@ -26,14 +26,16 @@ executors: | |||
| xpack.license.self_generated.type: trial | |||
| xpack.security.authc.api_key.enabled: true | |||
| ELASTIC_PASSWORD: password | |||
| - image: docker.elastic.co/enterprise-search/enterprise-search:7.8.0 | |||
| ES_JAVA_OPTS: -Xms512m -Xmx512m | |||
There was a problem hiding this comment.
This helps prevent the ES container from grinding to a halt during integration tests.
JasonStoltz
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version of Enterprise Search and Elasticsearch drifted since 7.8.0. Getting the test stack back up to the latest release.