-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Backend granularity (service.target.*) clarifications #674
Merged
Merged
Changes from 3 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d42311c
Backend granularity (service.target.*) clarifications
trentm dc82a08
tweak, nest-if-guards for db/message cases
trentm ea9c4c7
exists-check for 'name' case as well
trentm 5f1197d
add the start of my Q3
trentm fc95ebd
Merge branch 'main' into trentm/backend-granularity-q
trentm 5df58c6
first mismerge
trentm bebe220
update composite span.name to be calculated from service.target.*
trentm de440a0
tweak this description
trentm d315524
I believe this was a typo, json-specs/span_types.json suggests 'sqlse…
trentm 7992292
this was my Q2, but I accidentally inverted the logic
trentm 80f3782
Update "infer destination.service.resource" logic to be based on serv…
trentm 2a66234
(for Q5) update OTel Bridge compatibility mapping pseudo-code to set …
trentm File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REVIEW NOTE: This section slightly tweaks the pseudo-code to infer
context.service.target.*
from other span fields to avoid a couple gotchas that I hit:if (!service_target.type)
check in JavaScript would accidentally overrideservice_target.type
if it had explicitly been set to the empty string.if (span.context.db.instance)
branch was changed toif (span.context.db)
to use the DB logic for DB spans even if the span didn't happen to have a "db.instance" set -- which is less surprising and matches the old pseudo-code for inferring destination.service.resource.