-
Notifications
You must be signed in to change notification settings - Fork 114
Support for more k8s cgroup path patterns #344
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yet another flavour (Openshift build `bipr-form-disney-71`) turned out to not be discovered by our current regex: ``` 9:freezer:/kubepods.slice/kubepods-pod22949dce_fd8b_11ea_8ede_98f2b32c645c.slice/docker-b15a5bdedd2e7645c3be271364324321b908314e4c77857bbfd32a041148c07f.scope ```
SergeyKleyman
approved these changes
Sep 23, 2020
basepi
approved these changes
Sep 23, 2020
mikker
approved these changes
Sep 28, 2020
Good enough for me 🙂 . Merging |
Seems like this requires changes in all agents, right? To track these, could you add an agents issue table and create agent issues using this script? |
This was referenced Sep 30, 2020
astorm
added a commit
to astorm/container-info
that referenced
this pull request
Oct 8, 2020
Qard
pushed a commit
to Qard/container-info
that referenced
this pull request
Oct 9, 2020
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Oct 28, 2020
see elastic/apm#344 closes elastic#936
beniwohli
added a commit
to elastic/apm-agent-python
that referenced
this pull request
Nov 3, 2020
see elastic/apm#344 closes #936
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Yet another flavour (Openshift build
bipr-form-disney-71
) turned out to not be discovered by our current regex: