Skip to content

Support for more k8s cgroup path patterns #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 30, 2020

Conversation

eyalkoren
Copy link
Contributor

@eyalkoren eyalkoren commented Sep 23, 2020

Yet another flavour (Openshift build bipr-form-disney-71) turned out to not be discovered by our current regex:

9:freezer:/kubepods.slice/kubepods-pod22949dce_fd8b_11ea_8ede_98f2b32c645c.slice/docker-b15a5bdedd2e7645c3be271364324321b908314e4c77857bbfd32a041148c07f.scope
Agent Milestone Link to agent implementation issue
.NET elastic/apm-agent-dotnet#968
Go elastic/apm-agent-go#822
Java 7.10 elastic/apm-agent-java#1423
Node.js 7.10 elastic/apm-agent-nodejs#1821
PHP elastic/apm-agent-php#195
Python elastic/apm-agent-python#936
Ruby elastic/apm-agent-ruby#876

Yet another flavour (Openshift build `bipr-form-disney-71`) turned out to not be discovered by our current regex:
```
9:freezer:/kubepods.slice/kubepods-pod22949dce_fd8b_11ea_8ede_98f2b32c645c.slice/docker-b15a5bdedd2e7645c3be271364324321b908314e4c77857bbfd32a041148c07f.scope
```
@eyalkoren eyalkoren requested review from a team as code owners September 23, 2020 16:28
@apmmachine
Copy link

apmmachine commented Sep 23, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Started by timer]

  • Start Time: 2020-09-28T05:48:00.993+0000

  • Duration: 3 min 39 sec

@eyalkoren
Copy link
Contributor Author

Good enough for me 🙂 . Merging

@eyalkoren eyalkoren merged commit 8b1243a into master Sep 30, 2020
@eyalkoren eyalkoren deleted the relaxing-k8s-regex-further branch September 30, 2020 04:08
@felixbarny
Copy link
Member

Seems like this requires changes in all agents, right?

To track these, could you add an agents issue table and create agent issues using this script?

beniwohli added a commit to elastic/apm-agent-python that referenced this pull request Nov 3, 2020
beniwohli added a commit to beniwohli/apm-agent-python that referenced this pull request Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants