Skip to content

chore: upppercase API in the feature name #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Conversation

mdelapenya
Copy link
Contributor

@mdelapenya mdelapenya commented Mar 30, 2020

What is this PR doing?

It changes Api to API in the feature name, so no test step is affected. This is a follow-up of #231

Besides that, it removes the scripts that enabled pulling the gherkin files from a downstream repo

Why is it important?

We want to trigger the automation to synchronise all apm agents when the specs change

@mdelapenya mdelapenya self-assigned this Mar 30, 2020
@mdelapenya mdelapenya requested review from a team, estolfo and beniwohli March 30, 2020 22:02
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the git submodule required?

@mdelapenya
Copy link
Contributor Author

Is the git submodule required?

I don't know how that got into the PR. I would say it's not needed, so I'll remove that in a commit on top

Copy link
Contributor

@cachedout cachedout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved assuming the submodule is removed. :)

@mdelapenya
Copy link
Contributor Author

I found the submodule was added by (my) mistake, as it included a previous checkout in a previous iteration.

I pushed-force the last commit and it's not present anymore.

Thanks for the 👀!!

@mdelapenya mdelapenya merged commit 7f3af2c into master Mar 31, 2020
@mdelapenya mdelapenya deleted the mdelapenya-patch-1 branch March 31, 2020 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants