[ACM] Create Etag from settings struct. #2441
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simitt
force-pushed
the
2434-etag-with-version
branch
from
2fdbd48 to
99c730e
Compare
graphaelli
reviewed
Jul 12, 2019
To ensure Etag changes when config settings are updated, consider config settings when calculating ID for config object. fixes elastic#2434
simitt
force-pushed
the
2434-etag-with-version
branch
from
63c1872 to
d7ef9f1
Compare
graphaelli
reviewed
Jul 15, 2019
simitt
changed the title
7 tasks
graphaelli
reviewed
Jul 16, 2019
axw
reviewed
Jul 17, 2019
simitt
commented
Jul 17, 2019
graphaelli
reviewed
Jul 17, 2019
graphaelli
approved these changes
Jul 17, 2019
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 18, 2019
To ensure Etag changes when config settings are updated, consider config settings when calculating ID for config object. Return empty response body and etag for empty response if config not found. fixes elastic#2434
simitt
added a commit
to simitt/apm-server
that referenced
this pull request
Jul 18, 2019
To ensure Etag changes when config settings are updated, consider config settings when calculating ID for config object. Return empty response body and etag for empty response if config not found. fixes elastic#2434
simitt
added a commit
that referenced
this pull request
Jul 18, 2019
simitt
added a commit
that referenced
this pull request
Jul 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To ensure Etag changes when config settings are updated, include config settings when calculating ID for config object.
fixes #2434
backport to
7.xand7.3.fyi @felixbarny , @axw