support minor release create test plan workflow#20969
Conversation
|
This pull request does not have a backport label. Could you fix it @aelnahas? 🙏
|
🤖 GitHub commentsJust comment with:
|
carsonip
left a comment
There was a problem hiding this comment.
a way to test this would be to reuse the same workflow name, push it to a branch under elastic/apm-server, i.e. not your fork, then you can run it on GH actions. Only after testing you may rename it as you like. This is because GH requires a workflow to be on main for it to be shown on the UI.
In this case, since the workflow doesn't do much other than invoking the script and creating the issue, you may decide if the local validation is enough.
I'll do a review separately
|
Worth doing just to make sure the renaming doesnt cause issues |
carsonip
left a comment
There was a problem hiding this comment.
q on base tag decision logic. Since you already spent some time on it you might have a convincing answer ready
| exit 1 | ||
| fi | ||
| PREVIOUS_MINOR=$((MINOR - 1)) | ||
| PREVIOUS_TAG=$(git tag -l "v${MAJOR}.${PREVIOUS_MINOR}.*" | sort -V | tail -1) |
There was a problem hiding this comment.
I'm not sure if the base tag detection logic is 100% correct. And at the very least it should not depend on when the generate test plan script is run. It is not a simple question though, under the existing 2 active minors model - how do you decide if a change should show up in minor changelog, e.g. 9.4.0?
- Obviously, if a change is merged to 9.4 (either before or after FF) but not 9.3, it should be in 9.4.0 changelog
- But what if a bugfix is merged and due to be released in both 9.3.x and 9.4.0?
Motivation/summary
This PR will allow us to automate the test plan creation for minor releases
Changes that were done:
generate-test-plan.shto now handle minor releasescreate-test-plan-patchtocreate-test-planto avoid confusion now that it handles both minor and patch releasesChecklist
For functional changes, consider:
How to test these changes
for convenience here are the test plans that were created by invoking this script:
they werent created by the workflow rather I ran the script and pasted the output test plan as an issue to my fork.
Related issues
#20454