iserver-test: Fix BC 9.0 test #17571
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericywl
added
the
backport-skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
marclop
reviewed
Jul 11, 2025
| @@ -15,6 +15,12 @@ for bc in ${bcs}; do | |||
| if [[ ${major} -lt 8 ]]; then | |||
| continue | |||
| fi | |||
| # Specifically for 9.0, we set the upgrade path to be from 8.18, | |||
| # since 8.19 cannot upgrade to 9.0. | |||
There was a problem hiding this comment.
Why's that? Is there a legitimate reason for that?
There was a problem hiding this comment.
Its due to ES upgrade policy, upgrades can only be done in chronological order. Since latest 9.0 was released before latest 8.19, it cannot be upgraded to.
There was a problem hiding this comment.
But 8.19 can be upgraded to 9.1?
There was a problem hiding this comment.
Can you add this information in the comment, please? I'm sure others may have the same questions.
ericywl
force-pushed
the
iservertest-fix-bc-9.0-test
branch
from
a9adc2d to
56f39eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/summary
8.19 cannot upgrade to 9.0, so our BC test for 9.0 will always fail. This PR adds an edge case handling for 9.0, and also increase the APM server ready wait time.
How to test these changes
Run workflow: https://github.com/elastic/apm-server/actions/runs/16211738588