-
Notifications
You must be signed in to change notification settings - Fork 534
feat: use go-freelru consistently #16549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
replace all lru cache deps with go-freelru go-freelru requires a capacity so use a reasonable default
This pull request does not have a backport label. Could you fix it @kruskall? 🙏
|
This pull request is now in conflicts. Could you fix it @kruskall? 🙏
|
@Mergifyio backport 8.19 |
✅ Backports have been created
|
* feat: use go-freelru consistently replace all lru cache deps with go-freelru go-freelru requires a capacity so use a reasonable default * lint: update notice file * lint: run make fmt * lint: remove unused code (cherry picked from commit e0c9eda) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # go.sum # internal/agentcfg/cache_test.go # internal/agentcfg/kibana.go
* feat: use go-freelru consistently (#16549) * feat: use go-freelru consistently replace all lru cache deps with go-freelru go-freelru requires a capacity so use a reasonable default * lint: update notice file * lint: run make fmt * lint: remove unused code (cherry picked from commit e0c9eda) # Conflicts: # NOTICE-fips.txt # NOTICE.txt # go.mod # go.sum # internal/agentcfg/cache_test.go # internal/agentcfg/kibana.go * Update cache_test.go * Update kibana.go * lint: run go mod tidy --------- Co-authored-by: kruskall <99559985+kruskall@users.noreply.github.com>
@kruskall what are the performance and change in resource usage implications from this PR? |
performance didn't change much, this is mostly to drop deprecated/unmaintained libraries |
Tested for presence of the cache packages in the binary. For any version before 9.1, e.g. v9.0.1.
For 9.1
|
Motivation/summary
replace all lru cache deps with go-freelru
go-freelru requires a capacity so use a reasonable default
Checklist
For functional changes, consider:
How to test these changes
Related issues
Closes #16435