Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

github-action: use ephemeral tokens with the required permissions #2652

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Sep 9, 2024

Details

⚠️ This PR was created by an automated tool. Please review the changes carefully. ⚠️

What

Use https://github.com/tibdex/github-app-token to generate ephemeral tokens with the required
permissions only

This is the alternative to moving away from finer-grained GitHub tokens and reducing the
cumbersome of rotating them as we do nowadays.

Implementaiton details

We have used the same GitHub action in other places.

If there are any questions, please reach out to the @elastic/observablt-ci

@v1v v1v requested a review from a team as a code owner September 9, 2024 12:20
@v1v v1v self-assigned this Sep 9, 2024
@v1v
Copy link
Member Author

v1v commented Sep 9, 2024

CLA checker will cause some disruptions - I'm working on it with the relevant CLA owners. for now, I'll keep this draft to avoid surprises.

@v1v v1v marked this pull request as draft September 9, 2024 14:04
@v1v v1v marked this pull request as ready for review September 16, 2024 10:12
@v1v v1v merged commit 2e545ca into main Sep 17, 2024
8 checks passed
@v1v v1v deleted the gh-oblt/replace-token-with-app branch September 17, 2024 10:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants