Skip to content
This repository was archived by the owner on Oct 28, 2024. It is now read-only.

Support runE2E step #1325

Merged
merged 18 commits into from
Oct 19, 2021
Merged

Support runE2E step #1325

merged 18 commits into from
Oct 19, 2021

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 18, 2021 •
edited
Loading

@ghost
Copy link

ghost commented Oct 18, 2021 •
edited by ghost
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-10-19T09:45:38.337+0000

  • Duration: 13 min 18 sec

  • Commit: 9b35882

Test stats 🧪

Test Results
Failed 0
Passed 1228
Skipped 2
Total 1230

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run infra tests : Run the test-infra test.

@v1v v1v marked this pull request as ready for review October 18, 2021 11:38
@botelastic botelastic bot added the groovy label Oct 18, 2021
@v1v v1v requested review from a team October 18, 2021 11:40
@v1v v1v self-assigned this Oct 18, 2021
@v1v v1v added the enhancement New feature or request label Oct 18, 2021
mdelapenya
mdelapenya reviewed Oct 18, 2021
View reviewed changes
v1v
v1v commented Oct 18, 2021
View reviewed changes
vars/runE2e.groovy Outdated
booleanParam(name: 'forceSkipGitChecks', value: true),
booleanParam(name: 'forceSkipPresubmit', value: true),
booleanParam(name: 'notifyOnGreenBuilds', value: notifyOnGreenBuilds),
string(name: 'BEAT_VERSION', value: beatVersion),
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing runTestsSuites

@v1v v1v mentioned this pull request Oct 18, 2021
Merged
@v1v v1v mentioned this pull request Oct 18, 2021
Merged
@v1v
Copy link
Member Author

v1v commented Oct 18, 2021

I might revisit this implementation to normalise the parameters and extraParameters

mdelapenya
mdelapenya suggested changes Oct 18, 2021
View reviewed changes
Copy link
Contributor

@mdelapenya mdelapenya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For readability purpose, I'd rename the step to runE2E(...) instead of run E2e(...)

mdelapenya
mdelapenya reviewed Oct 19, 2021
View reviewed changes
Copy link
Contributor

@mdelapenya mdelapenya left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some references to the old name (runE2e). other than that LGTM

mdelapenya
mdelapenya reviewed Oct 19, 2021
View reviewed changes
mdelapenya
mdelapenya reviewed Oct 19, 2021
View reviewed changes
mdelapenya
mdelapenya reviewed Oct 19, 2021
View reviewed changes
vars/runE2E.txt Outdated
@@ -0,0 +1,30 @@
Trigger the end 2 end testing job.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about adding a link to the project?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added https://github.com/elastic/apm-pipeline-library/pull/1325/files#diff-d03b85a69fded50fce1ce456ae69d6b979751fedda5d6106d6d3bbd534f8f0fcR30

do you mean the the Jenkins job in addition to this one?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See 9b35882

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant the GH repo here, at the beginning of the docs

v1v and others added 4 commits October 19, 2021 10:43
@v1v
rename method addStringParameterIfValue
023ec56
@v1v @mdelapenya
Update src/test/groovy/RunE2EStepTests.groovy
8118c27 
Co-authored-by: Manuel de la Peña <mdelapenya@gmail.com>
@v1v
Merge branch 'feature/build-e2e-step' of github.com:v1v/apm-pipeline-…
4afd644 
…library into feature/build-e2e-step

* 'feature/build-e2e-step' of github.com:v1v/apm-pipeline-library:
  Update src/test/groovy/RunE2EStepTests.groovy
@v1v
update docs
e6202ea
v1v
v1v commented Oct 19, 2021
View reviewed changes
vars/gsutil.txt
@@ -9,5 +9,5 @@ Wrapper to interact with the gsutil command line. It returns the stdout output.
```

* command: The gsutil command to be executed. Mandatory
* credentialsId: The credentials to login to GCP. (Optional). See [withGCPEnv](#withGCPEnv)
* secret: Name of the secret on the the vault root path. (Optional). See [withGCPEnv](#withGCPEnv)
* credentialsId: The credentials to login to GCP. (Optional). See [withGCPEnv](#withgcpenv)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated

@v1v v1v changed the title Support runE2e step Support runE2E step Oct 19, 2021
@mergify mergify bot merged commit 50f6bee into elastic:master Oct 19, 2021
@v1v v1v deleted the feature/build-e2e-step branch October 19, 2021 10:07
v1v referenced this pull request in v1v/apm-pipeline-library Oct 26, 2021
@v1v
Merge remote-tracking branch 'upstream/master' into feature/source-of…
defe932 
…-truth-releases

* upstream/master: (220 commits)
  test-infra: test ARM workers (#1337)
  Weekly email for Beats (7.16 and master) (#1335)
  Add traces for GitHub release publish (#1333)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.255
  Fix parameter name (#1331)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.254
  Add more parameters in runE2E (#1328)
  fix: use Ubuntu workers (#1327)
  chore(deps): bump opentelemetry from 0.20 to 0.21 (#1323)
  Support runE2E step (#1325)
  docs: fix codespell (#1324)
  docs: update CHANGELOG.md
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release v1.1.253
  withGCPEnv: support secret from vault (#1320)
  pre-commit: fix linting (#1322)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
2 more reviewers

@mdelapenya mdelapenya mdelapenya approved these changes

@kuisathaverat kuisathaverat kuisathaverat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@v1v v1v

Labels
enhancement New feature or request groovy ready-to-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@v1v @mdelapenya @kuisathaverat