Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable stale bot for issues #914

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Conversation

v1v
Copy link
Member

@v1v v1v commented Oct 7, 2020

What

Enable stale bot to notify and then close the Issues that haven't had any activity for 120 days, a notification will be sent after 100 days and if nothing else happens they will get closed 20 days later.

How it works

  • Support issues only as stated
  • It uses the Stalled label to categorise the ones that have been informed without any activity in 120 days.
  • It looks for the issues that got the label discuss and question.
  • Those Stalled issues will be closed if no further activity after 20 days.
  • Those issues without a label are excluded from the bot. (There is no support for such). The workaround will be as simple as label them with Stalled then the bot will close them after 20 days.

Issues

Closes #912
Relates to elastic/beats#19157

Questions

@cachedout what do we do to enable the botelastic to work with this repo? I'll ask infra to enable it

@v1v v1v self-assigned this Oct 7, 2020
@v1v v1v added the automation label Oct 7, 2020
@v1v v1v marked this pull request as ready for review October 7, 2020 13:56
@v1v v1v requested a review from a team October 7, 2020 13:56
# Configuration for probot-stale - https://github.com/probot/stale

# Number of days of inactivity before an Issue or Pull Request becomes stale
daysUntilStale: 335
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels really long IMO, how about 3-6 months? Cleanup sooner also ensures we are picking and working on backlogs at some point. just a personal preference though? @jahtalab thoughts?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure thing, I just took what we got in place as a template, happy to change it :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should make a decision about an issue within 3-6 months (possibly even sooner than that but to reduce noise let's set it at 4 month). We either close the issue or add an appropriate label (e.g. bug, enhancement) to it.

@apmmachine
Copy link
Contributor

📦 Bundlesize report

Filename Size(bundled) Size(gzip) Diff(gzip)
elastic-apm-opentracing.umd.min.js 61.7 KiB 19.6 KiB 💚 0 Bytes
elastic-apm-rum.umd.min.js 55.7 KiB 18.2 KiB 💚 0 Bytes

@apmmachine
Copy link
Contributor

apmmachine commented Oct 7, 2020

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #914 updated]

  • Start Time: 2020-10-08T10:36:22.308+0000

  • Duration: 79 min 23 sec

Test stats 🧪

Test Results
Failed 0
Passed 1028
Skipped 10
Total 1038

Steps errors 1

Expand to view the steps failures

  • Name: Error signal
    • Description: The test failed

    • Duration: 0 min 0 sec

    • Start Time: 2020-10-08T11:14:26.401+0000

    • log

Copy link
Contributor

@hmdhk hmdhk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @v1v,

I think the condition for the which issues should be considered stale is not correct. We want issues with question, discuss labels to be considered stale. Also issues with no label should be considered stale as well.

But issues with any other label should be exempt from being stale.

# Configuration for probot-stale - https://github.com/probot/stale

# Number of days of inactivity before an Issue or Pull Request becomes stale
daysUntilStale: 335
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree, we should make a decision about an issue within 3-6 months (possibly even sooner than that but to reduce noise let's set it at 4 month). We either close the issue or add an appropriate label (e.g. bug, enhancement) to it.

# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
exemptLabels:
- question
- discuss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these two sets of labels are should be reversed.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aha! I actually read the description in the issue incorrectly! Thanks for the heads up :)

@v1v v1v changed the title chore: enable stale bot chore: enable stale bot for issues Oct 8, 2020
@v1v v1v requested review from hmdhk and vigneshshanmugam October 8, 2020 10:36
Copy link
Member

@vigneshshanmugam vigneshshanmugam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@v1v v1v merged commit 49fcf63 into elastic:master Oct 15, 2020
@v1v v1v deleted the feature/stale-bot branch October 15, 2020 10:48
David-Development pushed a commit to David-Development/apm-agent-rum-js that referenced this pull request Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide a bot to mark stale issues as such and close after some time
7 participants