-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: enable stale bot for issues #914
Conversation
.github/stale.yml
Outdated
# Configuration for probot-stale - https://github.com/probot/stale | ||
|
||
# Number of days of inactivity before an Issue or Pull Request becomes stale | ||
daysUntilStale: 335 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels really long IMO, how about 3-6 months? Cleanup sooner also ensures we are picking and working on backlogs at some point. just a personal preference though? @jahtalab thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure thing, I just took what we got in place as a template, happy to change it :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we should make a decision about an issue within 3-6 months (possibly even sooner than that but to reduce noise let's set it at 4 month). We either close the issue or add an appropriate label (e.g. bug
, enhancement
) to it.
📦 Bundlesize report
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @v1v,
I think the condition for the which issues should be considered stale is not correct. We want issues with question
, discuss
labels to be considered stale. Also issues with no label should be considered stale as well.
But issues with any other label should be exempt from being stale.
.github/stale.yml
Outdated
# Configuration for probot-stale - https://github.com/probot/stale | ||
|
||
# Number of days of inactivity before an Issue or Pull Request becomes stale | ||
daysUntilStale: 335 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree, we should make a decision about an issue within 3-6 months (possibly even sooner than that but to reduce noise let's set it at 4 month). We either close the issue or add an appropriate label (e.g. bug
, enhancement
) to it.
.github/stale.yml
Outdated
# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable | ||
exemptLabels: | ||
- question | ||
- discuss |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these two sets of labels are should be reversed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aha! I actually read the description in the issue incorrectly! Thanks for the heads up :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
What
Enable stale bot to notify and then close the Issues that haven't had any activity for 120 days, a notification will be sent after 100 days and if nothing else happens they will get closed 20 days later.
How it works
issues
only as statedStalled
label to categorise the ones that have been informed without any activity in 120 days.discuss
andquestion
.Stalled
issues will be closed if no further activity after 20 days.Stalled
then the bot will close them after 20 days.Issues
Closes #912
Relates to elastic/beats#19157
Questions
@cachedout what do we do to enable the botelastic to work with this repo?I'll ask infra to enable it