remove elasticsearch-async tests#949
Merged
beniwohli merged 1 commit intoelastic:masterfrom Oct 27, 2020
Merged
Conversation
elasticsearch-async has been deprecated and its functionality brought into elasticsearch-py proper (tests for that can be found in async_elasticsearch_client_tests.py). Since version 3.7 of aiohttp, the tests fail and can't easily be fixed. We plan to remove support for this module anyway in version 6.0 of the agent, so it's an acceptable quick fix to remove testing for the module now already.
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Oct 26, 2020
elasticsearch-async has been deprecated and its functionality brought into elasticsearch-py proper. Tests for this module have already been removed in elastic#949
💚 Flaky test reportTests succeeded. Test stats 🧪
|
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
basepi
approved these changes
Oct 26, 2020
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
elasticsearch-async has been deprecated and its functionality brought into elasticsearch-py proper (tests for that can be found in async_elasticsearch_client_tests.py). Since version 3.7 of aiohttp, the tests fail and can't easily be fixed. We plan to remove support for this module anyway in version 6.0 of the agent, so it's an acceptable quick fix to remove testing for the module now already.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
elasticsearch-async has been deprecated and its functionality brought
into elasticsearch-py proper (tests for that can be found in
async_elasticsearch_client_tests.py). Since version 3.7 of aiohttp,
the tests fail and can't easily be fixed. We plan to remove support
for this module anyway in version 6.0 of the agent, so it's an
acceptable quick fix to remove testing for the module now already.