Add log_level config #946
Merged
Add log_level config #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errors
Expand to view the steps failures
|
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
Also refactored one of the `call_callbacks` methods to `call_all_callbacks` for clarity.
This allows for callbacks to be config aware, and makes the full config available to callback functions.
|
I still need to figure out why the integration tests are failing... |
basepi
force-pushed
the
log_level
branch
4 times, most recently
from
daeea2b to
5bf29a0
Compare
basepi
added a commit
to basepi/apm-integration-testing
that referenced
this pull request
Nov 6, 2020
Previously, this didn't actually do anything because log_level was not an established config value for the python agent. As of elastic/apm-agent-python#946 this is now a setting in python and it was causing tests to fail due to the way python logging works. This PR cleans up all of those references and will make tests pass.
|
These tests should pass once elastic/apm-integration-testing#962 is merged. |
basepi
added a commit
to elastic/apm-integration-testing
that referenced
this pull request
Nov 7, 2020
* Remove ELASTIC_APM_LOG_LEVEL from python stuff Previously, this didn't actually do anything because log_level was not an established config value for the python agent. As of elastic/apm-agent-python#946 this is now a setting in python and it was causing tests to fail due to the way python logging works. This PR cleans up all of those references and will make tests pass. * Remove default for --apm-log-level All uses of this setting use `self.options.get` with a default, so we can remove the default in `argparse`. This allows the python agent to only use this setting if it's explicitly set, which is better for how the python agent's `log_level` works. * Fix lint
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Remove unused arg from conf.setup_logging * Add ValidValuesValidator * Add tests for ValidValuesValidator * Add support for callbacks_on_default Also refactored one of the `call_callbacks` methods to `call_all_callbacks` for clarity. * Add log_level config with stubbed callback * Don't run callbacks on copy operations * Move callbacks to the end of any update() operation This allows for callbacks to be config aware, and makes the full config available to callback functions. * Add log_file/size and implement logging setup callback * Fix docs link * Add changelog * Audit logger calls * Don't mess with global logging library * Add tests * Fix missing arg for ConfigurationError * Import logging.handlers * Implement review suggestions * Fix windows tests * Don't set log_level by default * Better handling for callbacks if default is None * With new default handling, don't need to check for new_value * Allow `warn` in addition to `warning` for log_level
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for configurable
log_level.Spec
Related issues
Closes #941