Add support for callbacks on config change #912
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Steps errorsExpand to view the steps failures
|
basepi
commented
Sep 1, 2020
beniwohli
reviewed
Sep 2, 2020
Also added a _dict_key_lookup to _ConfigBase to allow for easy access to _ConfigValue instances via dict_key
houndci-bot
reviewed
Sep 3, 2020
|
@beniwohli Something I realized while trying to figure out how to test this today -- callbacks will also be called on initial Config creation, for any non-default values. I think this is probably ok and expected behavior? But it's something to note, and I wondered if you saw any issues with that. I feel like any operation you want to perform on config change probably needs to be performed on initialization as well, if the config value is different than the default value, but I'm not certain. |
beniwohli
approved these changes
Sep 29, 2020
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Add support for callbacks on config value change * Fix VersionedConfig.reset() Also added a _dict_key_lookup to _ConfigBase to allow for easy access to _ConfigValue instances via dict_key * Remove unused variable, and use compat.iteritems * Use default values for old_value comparison in callbacks * Add remote config callback test * Add to changelog * Workaround for no nonlocal keyword in py2 * Add nonlocal note * Add a reset() callback test, plus a typo fix
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
* Add support for callbacks on config value change * Fix VersionedConfig.reset() Also added a _dict_key_lookup to _ConfigBase to allow for easy access to _ConfigValue instances via dict_key * Remove unused variable, and use compat.iteritems * Use default values for old_value comparison in callbacks * Add remote config callback test * Add to changelog * Workaround for no nonlocal keyword in py2 * Add nonlocal note * Add a reset() callback test, plus a typo fix
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Add support for callbacks on config value change * Fix VersionedConfig.reset() Also added a _dict_key_lookup to _ConfigBase to allow for easy access to _ConfigValue instances via dict_key * Remove unused variable, and use compat.iteritems * Use default values for old_value comparison in callbacks * Add remote config callback test * Add to changelog * Workaround for no nonlocal keyword in py2 * Add nonlocal note * Add a reset() callback test, plus a typo fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Adds the ability to specify one or more "callback" functions which will be called when a
_ConfigValueis changed.Related issues
closes #908