Update the pid/ppid in transport metadata if they have changed #825
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💔 Tests Failed
Expand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Log outputExpand to view the last 100 lines of log output
|
|
@beniwohli this could still use a review when you have a moment. |
beniwohli
reviewed
Jun 3, 2020
Also made build_metadata a public method in the client
|
@beniwohli I realized when writing the test that if we generate metadata at start_thread time, we would lose any metadata explicitly set in the Transport kwargs. This was problematic for testing, but also begged the question: why would we bother generating it at all before we create the Transport, when it's going to be immediately overwritten when we start the thread? So now we store any metadata that is sent into the Transport as This is a much larger-scale change now, and I'm interested in your opinion. |
beniwohli
reviewed
Jun 4, 2020
|
Just flakey tests failing. Merging. |
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
…ic#825) * Update the pid/ppid in transport metadata if they have changed * Only update the process metadata if it already exists * Fix os.getppid for windows python 2.7 * Add to changelog * Rebuild metadata on pid change Also made build_metadata a public method in the client * Generate metadata only during start_thread * Remove metadata kwarg from transport completely * Remove metadata :param
romulorosa
pushed a commit
to romulorosa/apm-agent-python
that referenced
this pull request
Oct 15, 2020
…ic#825) * Update the pid/ppid in transport metadata if they have changed * Only update the process metadata if it already exists * Fix os.getppid for windows python 2.7 * Add to changelog * Rebuild metadata on pid change Also made build_metadata a public method in the client * Generate metadata only during start_thread * Remove metadata kwarg from transport completely * Remove metadata :param
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
…ic#825) * Update the pid/ppid in transport metadata if they have changed * Only update the process metadata if it already exists * Fix os.getppid for windows python 2.7 * Add to changelog * Rebuild metadata on pid change Also made build_metadata a public method in the client * Generate metadata only during start_thread * Remove metadata kwarg from transport completely * Remove metadata :param
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Closes #792