Fix error with missing content-type header in Starlette #763
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Grrr, somehow my |
beniwohli
approved these changes
Mar 19, 2020
|
I don't know why CLA hates me right now. I'm just going to merge it. |
|
Apparently commenting fixed it? Github hates me tonight. |
|
And second comment broke it again. Guess I'll just spam until it goes green? :lolsob: |
beniwohli
pushed a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Run black (how was this missed?) * Don't assume "content-type" header is present * Better error handling around body capture * Add test for POST with body * Fix isort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fix Starlette request body collection for missing content-type header.
Sorry for the noise from
black. Not sure how it wasn't run on these files previously..... Might be worth investigation.