set the span id as parent id when errors happen in spans #669
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
If available, sets the error.parent_id to span.id
We need to handle a few different cases. When the exception
is captured inside the span, we can get the span from the
execution context.
More complicated is the case when the exception isn't handled
inside the span. In this case, the span is already ended when
the exception is handled, and not available in the execution
context. To work around this, we need to store the span ID
as an attribute of the exception value, where we can grab
it when the exception is captured later on. This isn't
supper pretty, but works.
Why is it important?
Using this information, the UI can show exceptions and logs
directly in the span object.