flask: close the transaction in the exception handler #635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `request_finished` signal isn't sent if an unhandled exception occurs, and other signals (e.g. `request_teardown` don't provide the `response` object. fixes #629
basepi
approved these changes
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
The
request_finishedsignal isn't sent if an unhandled exceptionoccurs, and other signals (e.g.
request_teardowndon't provide theresponseobject.As a workaround, we close the transaction in the exception handler.
This requires us to move some logic into the
request_startedhandlerto ensure it is run.
Unfortunately, this means we don't have any response context data,
as the response isn't created yet when the exception handler is called.
Why is it important?
So far, no transaction at all is captured when an error occurs. While
this solution isn't perfect, it gets us pretty close without having
to resort to wrapping/patching Flask APIs.
Related issues
closes #629