added instrumentation for mysql-connector and pymysql #603
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mysql-connector uses `platform.linux_distribution()`, which was removed in Python 3.8
basepi
approved these changes
Oct 9, 2019
|
Very excited and in need of this one 👍 |
…ic#631) When the systemd cgroup driver is used, cgroup paths will have hyphens (e.g. in pod UIDs) escaped to underscores. When we're parsing cgroups, we must therefore unescape them. refs elastic/apm#165
looks like it's been fixed upstream!
|
@holdenrehg this has now been released in version 5.3.0 of the agent. Would love to hear if it works for you! |
Awesome. I'll give it a test this week and let you know! |
|
@beniwohli works just as expected for me now after bumping up to the latest version ( For context, I'm using Flask and "SQLALCHEMY_DATABASE_URI": "mysql+mysqlconnector://{username}:{password}@{host}:{port}/{database}"
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.