Skip to content

respect the NO_PROXY environment variable #551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

respect the NO_PROXY environment variable #551

wants to merge 2 commits into from

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Aug 6, 2019 •
edited by lreuven
Loading

also, use stdlib functions to get the proxy url

fixes #458

@beniwohli
respect the NO_PROXY environment variable
37cd86d 
also, use stdlib functions to get the proxy url

fixes elastic#458
@beniwohli beniwohli requested a review from bmorelli25 August 6, 2019 12:48
bmorelli25
bmorelli25 approved these changes Aug 6, 2019
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One capitalization nit. Good catch on the "APM server" -> "APM Server" fixes as well.

@beniwohli @bmorelli25
Update docs/configuration.asciidoc
916dc14 
Co-Authored-By: Brandon Morelli <bmorelli25@gmail.com>
@beniwohli beniwohli closed this in 47286d7 Aug 14, 2019
@beniwohli beniwohli deleted the fix-458 branch August 15, 2019 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NO_PROXY not passed
2 participants
@beniwohli @bmorelli25