Breakdown metrics #535
Breakdown metrics #535
Conversation
…acers e.g. tests.instrumentation.transactions_store_tests.test_tag_with_non_string_value
|
|
||
| def test_bare_transaction(elasticapm_client): | ||
| elasticapm_client.begin_transaction("request") | ||
| time.sleep(0.005) |
There was a problem hiding this comment.
I think we should enable callers to supply the duration to end_transaction, end_span, etc. Other tracing APIs allow specifying the end timestamp, which is of dubious value given wall clocks can jump... but being able to specify the duration is at least useful here, so we can specify the duration and check the exact value below. It could also be useful for integrating with other tracing systems.
In the Go agent, we only set the span's duration in the end method if it hasn't already been set, and it looks like this approach would work well in the Python agent too -- an optional arg would be fine too. In case the duration were specified, you work out the end timestamp as self.start_time + self.duration and pass that into child_ended.
There was a problem hiding this comment.
Makes sense, but if you're ok with it, I'll do that in a separate PR after the 5.0 release
on CI, these upper bounds are randomly broken due to slow machines
implements #479