Skip to content

store the URL of instrumented requests/urllib3 spans in the correct place #394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

store the URL of instrumented requests/urllib3 spans in the correct place #394

wants to merge 2 commits into from

Conversation

beniwohli
Copy link
Contributor

@beniwohli beniwohli commented Jan 29, 2019 •
edited by alvarolobato
Loading

fixes #393

@beniwohli beniwohli requested a review from graphaelli January 29, 2019 07:55
@beniwohli beniwohli mentioned this pull request Jan 29, 2019
Closed
@beniwohli
Copy link
Contributor Author

jenkins test this

@beniwohli beniwohli closed this in 0983b93 Jan 30, 2019
@beniwohli beniwohli deleted the fix-393 branch January 30, 2019 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graphaelli graphaelli graphaelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

move context.url to context.http.url
2 participants
@beniwohli @graphaelli