-
Notifications
You must be signed in to change notification settings - Fork 227
system metrics (CPU/memory) #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1248ca9
to
d499d8b
Compare
we still deviate quite a bit from what the go agent shows, so further bugs are probably lurking
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great on first pass. I'd like to spend some more time with it and try collecting real metrics if time permits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Am I doing something wrong? This shows a warning on python2.7:
>>> from elasticapm import Client
>>> client = Client()
No handlers could be found for logger "elasticapm.metrics"
and this has a different result in python3.7:
>>> from elasticapm import Client
>>> client = Client()
Could not register elasticapm.metrics.sets.cpu.CPUMetricSet metricset: psutil not found. Install it to get system and process metrics
@graphaelli re logging: can you use https://pypi.org/project/logging_tree/ to print the logger tree in both environments? |
The warnings (of course) goes away in 2.7 with psutil installed. Without, here is the logging_tree printout: python2.7:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Recapping offline discussion.. Code looks great and I will follow up with real life testing on mac os. I do think there's a chance non-linux + non-psutil users will complain about that logging warning but we can address that later, if needed.
c38baf4
to
669fae8
Compare
669fae8
to
3b291f4
Compare
No description provided.