move queue size logic into a lock-protected block #351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axw
reviewed
Dec 4, 2018
this avoids some weird special cases, and maintains more or less the same functionality, as GzipFile(compresslevel=0) also disables gzip compression
axw
approved these changes
Dec 4, 2018
we call a method of the object two lines up, so it's safe to assume that it is not None. We _probably_ could also remove the check if queued_data.fileobj is None, but I'm not 100% sure
beniwohli
added a commit
that referenced
this pull request
Dec 5, 2018
also, move queue size logic into a lock-protected block. This avoids some weird special cases, and maintains more or less the same functionality, as GzipFile(compresslevel=0) also disables gzip compression
|
closed in 4425fad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a shot in the dark to fix #348 as I wasn't able to reproduce.
The idea is to move the size check into a code block that is protected by the thread lock, and also to make sure to check that
fileobjexists.