added special handling for partials in get_name_from_func #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beniwohli
changed the title
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 23, 2018
graphaelli
approved these changes
Sep 24, 2018
| if isinstance(func, partial_types): | ||
| return "partial({})".format(get_name_from_func(func.func)) | ||
| elif hasattr(func, "_partialmethod"): | ||
| return "partial({})".format(get_name_from_func(func._partialmethod.func)) |
There was a problem hiding this comment.
any reason to worry about func not existing? eg user defined _partialmethod on their class?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@graphaelli @roncohen any opinion on wrapping the resulting name with "partial()" to denote that the wrapped function was a partial?
fixes #293
closes #294