Skip to content

Conversation

colleenmcginnis
Copy link
Contributor

Fixes image paths to work with docs-assembler.

Notes for the reviewer:

  • I was not able to get images in reference, extend, or release-notes to work using the :::{image} syntax because it seems to resolve differently than the Markdown ![]() syntax. We should address this in docs-builder, but in order to get images working as soon as possible, I've used Markdown syntax and left us a TO DO in a code comment to add back the screenshot class where applicable.

@colleenmcginnis colleenmcginnis added docs Team:Docs Label for the Observability docs team labels Apr 15, 2025
@colleenmcginnis colleenmcginnis requested review from a team April 15, 2025 22:12
@colleenmcginnis colleenmcginnis self-assigned this Apr 15, 2025
Copy link

@mdbirnstiehl mdbirnstiehl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐦 🦭

@colleenmcginnis colleenmcginnis merged commit 693318c into elastic:main Apr 15, 2025
9 checks passed
@colleenmcginnis colleenmcginnis deleted the fix-images-when-assembled branch April 15, 2025 22:17
v1v added a commit that referenced this pull request May 1, 2025
…-images

* feature/workflow-build-images:
  Revert "enable docker buildx"
  enable docker buildx
  github container registry
  Use github container registry
  Update .ci/docker/README.md
  publihs
  run manually
  docs
  run pr
  github-actions: build images
  build(deps): bump certifi from 2025.1.31 to 2025.4.26 in /dev-utils (#2282)
  build(deps): bump wolfi/chainguard-base from `1c7f5aa` to `67d82bc` (#2280)
  build(deps): bump docker/build-push-action (#2281)
  chore: deps(updatecli): Bump updatecli version to v0.98.0 (#2276)
  fix image paths for docs-assembler (#2274)
  [DOCS] Specifies no known issues (#2272)
  tests: skip client verify_server_cert disabling tests in fips mode (#2270)
  build(deps): bump wolfi/chainguard-base from `c56628d` to `1c7f5aa` (#2271)
  update apm links (#2268)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-python docs Team:Docs Label for the Observability docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants