Skip to content

fix: only set ELASTIC_CI_POST_VERSION when needed (Closes #2015) #2016

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

amannocci
Copy link
Contributor

What is the change being made?

  • Set ELASTIC_CI_POST_VERSION only when needed.

Why is the change being made?

  • The literal value '' is coerced to false and, as a result, the environment variable is always set on tag release.

Related Issues

Closes #2015

Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
@amannocci amannocci requested a review from xrmx March 27, 2024 12:46
@amannocci amannocci requested a review from a team March 27, 2024 12:46
Copy link
Member

@v1v v1v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🙏

@amannocci amannocci enabled auto-merge (squash) March 27, 2024 12:54
@amannocci amannocci merged commit d43253f into main Mar 27, 2024
@amannocci amannocci deleted the fix/release-process branch March 27, 2024 13:05
@xrmx
Copy link
Member

xrmx commented Mar 27, 2024

Thanks!

xrmx pushed a commit to xrmx/apm-agent-python that referenced this pull request Apr 3, 2024
… (elastic#2016)

Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
xrmx pushed a commit that referenced this pull request Apr 4, 2024
Signed-off-by: Adrien Mannocci <adrien.mannocci@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Investigate local version in production packages
4 participants