Skip to content

Feature/git 521 sanic apm contrib #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 26 commits into from
Nov 11, 2021
Merged

Feature/git 521 sanic apm contrib #1390

merged 26 commits into from
Nov 11, 2021

Conversation

ahopkins
Copy link
Contributor

@ahopkins ahopkins commented Nov 9, 2021

What does this pull request do?

Is a cleanup of @harshanarayana PR (#1056) to add compat with Sanic v21.9

Related issues

closes #521

harshanarayana and others added 24 commits April 18, 2021 09:42
@harshanarayana
GIT-521: add support for sanic framework
f09e12f
@harshanarayana
GIT-521: add base test infra configuration
f8df92a
@harshanarayana
GIT-521: refactor and address review comments from @ahopkins
4a3a96e
@harshanarayana
GIT-521: fix transaction name generation workflow
3122e03
@harshanarayana
GIT-521: enable documentation for sanic contrib
4bc656d
@harshanarayana
GIT-521: add callback info to documentation
50374e0
@harshanarayana
GIT-521: cleanup invalid html file
5e8ed0e
@harshanarayana
GIT-521: add monkey patch for exception handler
30c24c6
@harshanarayana
GIT-521: mark exception as handled
159a483
@harshanarayana
GIT-521: cleanup exception handler setup
908b8e2
@harshanarayana
GIT-521: add instance check before setting up apm exception handler
c9d6f3b
@harshanarayana
GIT-521: move types into reusable file
9cb8645
@harshanarayana
GIT-521: cleanup unsed types
3350fb0
@harshanarayana
GIT-521: fix header sanitization and exception tracker
b5c71f2
@harshanarayana
GIT-521: add additional tests and transaction name generation
819e9a3
@harshanarayana
GIT-521: fix tests client compatibility mode
d23661a
@harshanarayana
GIT-521: fix tests for new sanic router
beb9f09
@beniwohli
Merge branch 'master' into feature/GIT-521-sanic-apm-contrib
3e79cf8
@beniwohli
exclude sanic tests in Python 3.6
4f535b4 
We only support async tracing in Python 3.7+
@basepi
Merge branch 'master' into feature/GIT-521-sanic-apm-contrib
bb58841
@basepi
Merge branch 'master' into feature/GIT-521-sanic-apm-contrib
1ae5422
@ahopkins
Pull in latest and merge conflicts
56e4782
@ahopkins
Add arbitrary arg capture to ErrorHandler
4bf5d2c
@ahopkins
Implement changes from PR review
060ead3
@cla-checker-service
Copy link

cla-checker-service bot commented Nov 9, 2021 •
edited
Loading

💚 CLA has been signed

@github-actions github-actions bot added agent-python community Issues opened by the community triage Issues awaiting triage labels Nov 9, 2021
@ahopkins ahopkins mentioned this pull request Nov 9, 2021
Closed
3 tasks
@apmmachine
Copy link
Contributor

apmmachine commented Nov 9, 2021 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-11-11T17:38:28.536+0000

  • Duration: 34 min 16 sec

  • Commit: ce69f9d

Test stats 🧪

Test Results
Failed 0
Passed 10263
Skipped 9369
Total 19632

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@basepi
Copy link
Contributor

basepi commented Nov 10, 2021

/test

@basepi
Copy link
Contributor

basepi commented Nov 10, 2021

@ahopkins Can you sign the CLA please?

@basepi basepi self-assigned this Nov 10, 2021
@ahopkins
Copy link
Contributor Author

ahopkins commented Nov 10, 2021 •
edited
Loading

@ahopkins Can you sign the CLA please?

I did 😒 is it not showing?

@ajaygupta2790
Copy link
Contributor

This branch is out-of-date with the base branch
@ahopkins you need to sync with base branch, there was a release an hour ago

@ahopkins
Copy link
Contributor Author

This branch is out-of-date with the base branch
@ahopkins you need to sync with base branch, there was a release an hour ago

I was waiting to see if the elasticsearch-ci/docs would succeed or not.

@ahopkins
Copy link
Contributor Author

😢 broken tests

@ahopkins
Copy link
Contributor Author

@ajaygupta2790 @basepi I am not sure what to make of that failure. Please LMK.

@ajaygupta2790
Copy link
Contributor

😢 broken tests

I built this PR on my local and all test cases passed for sanic and python 3.7. @basepi need your support here.

@ajaygupta2790
Copy link
Contributor

/test

1 similar comment
@basepi
Copy link
Contributor

basepi commented Nov 11, 2021

/test

@basepi
Copy link
Contributor

basepi commented Nov 11, 2021

Sorry, sometimes the CLA takes a bit to show up. It's showing green now so we're good! Once the tests run again I'll look at any failures that remain.

@basepi
Copy link
Contributor

basepi commented Nov 11, 2021

run elasticsearch-ci/docs

@basepi
Copy link
Contributor

basepi commented Nov 11, 2021

/test

@basepi
Copy link
Contributor

basepi commented Nov 11, 2021

run elasticsearch-ci/docs

@basepi basepi merged commit 8b86b48 into elastic:master Nov 11, 2021
@ahopkins ahopkins deleted the feature/GIT-521-sanic-apm-contrib branch November 11, 2021 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@basepi basepi

Labels
agent-python community Issues opened by the community triage Issues awaiting triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: Enable support for Sanic
6 participants
@ahopkins @apmmachine @basepi @ajaygupta2790 @harshanarayana @beniwohli