Fix issue when resetting config after new value has been added #1068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
* Refactor auto_ecs_logging to log_ecs_formatting This matches the Java implementation which is more flexible (due to using an enum instead of a bool) and will match the upcoming ecs log formatting spec * `override`, not `on` * Update the test 🤦♂️
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Mar 16, 2021
…ic#1068) * add test that demonstrates problem from elastic#1067 * check if key existed in original config before setting up callback for it
beniwohli
added a commit
that referenced
this pull request
Mar 16, 2021
* Use `elasticapm` as Django app label Django 3.2 now verifies that the app label is a valid Python identifier name. * use `re_path` instead of `url` if available this reduces the deprecation warning noise in newer Django releases * added Django 3.2 to test matrix * Fix issue when resetting config after new value has been added (#1068) * add test that demonstrates problem from #1067 * check if key existed in original config before setting up callback for it * update changelog
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
…ic#1068) * add test that demonstrates problem from elastic#1067 * check if key existed in original config before setting up callback for it
beniwohli
added a commit
to beniwohli/apm-agent-python
that referenced
this pull request
Sep 14, 2021
* Use `elasticapm` as Django app label Django 3.2 now verifies that the app label is a valid Python identifier name. * use `re_path` instead of `url` if available this reduces the deprecation warning noise in newer Django releases * added Django 3.2 to test matrix * Fix issue when resetting config after new value has been added (elastic#1068) * add test that demonstrates problem from elastic#1067 * check if key existed in original config before setting up callback for it * update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a new value has been added to the config, resetting to the original config can raise a
KeyErrorRelated issues
closes #1067