Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updatecli: dynamic specs #1123

Merged
merged 5 commits into from
Jan 26, 2024
Merged

updatecli: dynamic specs #1123

merged 5 commits into from
Jan 26, 2024

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 16, 2024

What does this PR do?

Test

GITHUB_WORKSPACE=/tmp \
  PATH=/opt/homebrew/bin:$PATH \
  GIT_USER="Victor Martinez" \
  GIT_EMAIL="VictorMartinezRubio@gmail.com" \
  GITHUB_TOKEN=$(gh auth token) \
  updatecli apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml --debug

or without pushing any changes

GITHUB_WORKSPACE=/tmp \
  PATH=/opt/homebrew/bin:$PATH \
  GIT_USER="Victor Martinez" \
  GIT_EMAIL="VictorMartinezRubio@gmail.com" \
  GITHUB_TOKEN=$(gh auth token) \
  updatecli apply --config .ci/updatecli/updatecli.d --values .ci/updatecli/values.yml --push=false --debug

additionally, you can change the org from elastic to your own GitHub avatar.

#1124 was created accordingly

@v1v v1v requested review from a team January 16, 2024 20:22
@v1v v1v self-assigned this Jan 16, 2024
.ci/updatecli/updatecli.d/update-json-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli/updatecli.d/update-specs.yml Outdated Show resolved Hide resolved
.ci/updatecli/updatecli.d/update-gherkin-specs.yml Outdated Show resolved Hide resolved
@v1v v1v merged commit fe41679 into elastic:main Jan 26, 2024
148 checks passed
@intuibase
Copy link
Contributor

Hey @v1v
What is the background to this change?
What does this tool give us?

@v1v
Copy link
Member Author

v1v commented Jan 26, 2024

What is the background to this change?

It used to have defined the json-specs and specs from elastic/apm and elastic/apm-data in a static manner, so if for some reason those specs were renamed then they will be required to be changed in the updatecli pipeline. That's not convenience when there are 8 APM Agents.

If you search for Simplify tests specs update from APM to APM agents in this PR you can find the link to the private GitHub repository with the context.

What does this tool give us?

That particular automation was already put in place in #889

Back in the days, we used to centralise all those changes but we came up with the proposal to let the consumers own the automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants