fix: don't throw on older versions of Node.js 6 #711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `url.URL` object was added in Node.js v6.13.0. If you tried to perform a `foo instanceof url.URL` on earlier versions, the code would throw the following exception: TypeError: Expecting a function in instanceof check, but got undefined
Qard
approved these changes
Dec 5, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
url.URLobject was added in Node.js v6.13.0. If you tried to perform afoo instanceof url.URLon earlier versions, the code would throw the following exception:This is a prerequisite for #705 but might also solve #710 - We'll see when it's merged into master.