test(express-graphql): update test and patch ranges to match #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watson
reviewed
Oct 30, 2018
Contributor
watson
left a comment
watson
left a comment
There was a problem hiding this comment.
The existing tav tests for 0.6, should just be locked to ^0.6.12 (as per my 4 suggestions).
Then we should add a new set of tav tests to test the >=0.7.0 range below. There should be 3 groups, one for each of the peer dependencies graphql@^0.12.0, graphql@^0.13.0, and graphql@^14.0.0 which are the ones supported by the >=0.7.0 range.
Qard
force-pushed
the
update-express-graphql
branch
from
0482ee9 to
3cc0b5d
Compare
Qard
force-pushed
the
update-express-graphql
branch
from
3cc0b5d to
6b59e9a
Compare
2 tasks
watson
approved these changes
Oct 31, 2018
Contributor
watson
left a comment
watson
left a comment
There was a problem hiding this comment.
I assume v0.7.0 is excluded from the tav tests because it's broken.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI is failing right now because express-graphql 0.7.x was released and, while the tav ranges tried to test against them, the patch range did not apply the patch, resulting in test failures.