Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add support for tedious v19 #4219

Merged
merged 2 commits into from
Sep 6, 2024
Merged

feat: add support for tedious v19 #4219

merged 2 commits into from
Sep 6, 2024

Conversation

david-luna
Copy link
Member

Closes: #4218

Checklist

  • Implement code
  • Update tests
  • Update TypeScript typings
  • Update documentation
  • Add CHANGELOG.asciidoc entry
  • Commit message follows commit guidelines

@david-luna david-luna changed the title feat: add support for v19 feat: add support for tedious v19 Sep 5, 2024
trentm
trentm reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there be a .tav.yml addition as well? Something like:

  - versions:
      include: ">=19 <20"
      mode: latest-majors
    node: '>=18.17'
    command: ...

@david-luna
Copy link
Member Author

Should there be a .tav.yml addition as well? Something like:

  - versions:
      include: ">=19 <20"
      mode: latest-majors
    node: '>=18.17'
    command: ...

yes, thanks for catching it :)

trentm
trentm approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/test tav tedious

@david-luna david-luna merged commit 77d5c28 into main Sep 6, 2024
22 checks passed
@david-luna david-luna deleted the dluna/tedious-19-support branch September 6, 2024 21:13
@david-luna david-luna mentioned this pull request Sep 16, 2024
Merged
2 tasks
david-luna added a commit that referenced this pull request Oct 8, 2024
@david-luna
feat: add support for tedious v19 (#4219)
200de70
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trentm trentm trentm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for tedious@19
2 participants
@david-luna @trentm