ESM instrumentation/hooking fails with Node.js v18.19.0

[david-luna]

Out CI stated failing recently in the test action only for node v18 on a specific test script tests/instrumentation/fixtures/use-knex-pg.mjs.
https://github.com/elastic/apm-agent-nodejs/actions/runs/7161350478/job/19496836227

The error reveals that the script is ran twice and a racing condition occurs when creating the database in postgres. The reason behind this double load seem to be a backport (from v20) of the loading process of modules.
nodejs/node#44710

We can reproduce with a small project

// package.json
{
  "name": "iitm-double-load",
  "version": "1.0.0",
  "author": "",
  "license": "ISC",
  "dependencies": {
    "import-in-the-middle": "^1.5.0"
  }
}

// file index.mjs
import { isMainThread } from 'worker_threads';

console.log('index module is loaded!!!', isMainThread);

You can see the module is loaded in the main and also in a worker thread

NODE_OPTIONS="--experimental-loader=import-in-the-middle/hook.mjs" NODE_NO_WARNINGS=1 node ./index.mjs
index module is loaded!!! false
index module is loaded!!! true

[trentm]

workaround in ^^
The correct fix is an update of IITM with a fix.

[trentm]

IITM v1.6.0 was just released to fix this:

 '1.6.0': '2023-12-11T17:01:48.278Z'

So I guess we could have just waited an hour. :)

[david-luna]

IITM fix in nodejs/import-in-the-middle#44
Dependabot PR #3797