Add central config to config source list #763
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eyalkoren
approved these changes
Aug 1, 2019
| @@ -11,6 +11,7 @@ which have different naming conventions for the property key. | |||
| The first configuration sources override the configuration values of over the latter sources. | |||
|
|
|||
| [arabic] | |||
| . {kibana-ref}/agent-configuration.html[Central configuration] | |||
There was a problem hiding this comment.
This change looks good, but I have trouble understanding the English in the sentence above:
The first configuration sources override the configuration values of over the latter sources.
Is that proper?
There was a problem hiding this comment.
@bmorelli25 will know. I'm sure there's a better way to express that even if it was technically correct. But as that has not been changed in this PR, I'll merge this one and will do a follow-up once Brandon is back next week.
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.