Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concurrency fixes #997

Merged
merged 2 commits into from
Aug 5, 2021
Merged

Concurrency fixes #997

merged 2 commits into from
Aug 5, 2021

Commits on Aug 5, 2021

  1. module/apmhttp: add locking to httptrace handlers 

    Add synchronisation to requestTracer. Sayeth the httptrace docs:

> Functions may be called concurrently from different goroutines and
some may be called after the request has completed or failed.

There's also a minor enhancement here to set the Connect span outcome
to "failure" if an error occurred.
    @axw
    axw committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    b7aa8dc View commit details
    Browse the repository at this point in the history

  2. apm: fix deadlock in breakdown metrics calculation 

    Fix a deadlock that can occur when concurrently ending
a parent and child span, due to the parent waiting for
the child to release the transaction lock, and the child
waiting to lock the parent. Locks are now taken in a
consistent order.
    @axw
    axw committed Aug 5, 2021
    Configuration menu
    Copy the full SHA
    c0a1786 View commit details
    Browse the repository at this point in the history