Implement central config polling #591
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
@@ Coverage Diff @@
## master #591 +/- ##
=========================================
+ Coverage 84.64% 84.7% +0.05%
=========================================
Files 121 122 +1
Lines 7218 7419 +201
=========================================
+ Hits 6110 6284 +174
- Misses 791 806 +15
- Partials 317 329 +12
Continue to review full report at Codecov.
|
We introduce a new package, apmconfig, which defines a Watcher interface that can be used for watching for central config changes. When creating a new Tracer, it will use its Transport for watching config if it implements apmconfig.Watcher. The default HTTP transport implements that interface. The default behaviour of watching config can be disabled by setting the new environment variable ELASTIC_APM_CENTRAL_CONFIG to "false". For now only the sampler can be updated via central config. While there is central sampling config defined, any locally defined Sampler will be disregarded, whether it be specified via environment variable or via SetSampler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We introduce a new package, apmconfig, which
defines a Watcher interface that can be used
for watching for central config changes.
When creating a new Tracer, it will use its
Transport for watching config if it implements
apmconfig.Watcher. The default HTTP transport
implements that interface.
The default behaviour of watching config can
be disabled by setting the new environment
variable ELASTIC_APM_CENTRAL_CONFIG to "false".
For now only the sampler can be updated via
central config. While there is central sampling
config defined, any locally defined Sampler will
be disregarded, whether it be specified via
environment variable or via SetSampler.
Closes #512